lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 20 Nov 2020 01:33:01 +0000
From:   HORIGUCHI NAOYA(堀口 直也) 
To:     Oscar Salvador <>
CC:     "" <>,
        "" <>,
        "" <>,
        "" <>
Subject: Re: [PATCH 1/7] mm,hwpoison: Refactor get_any_page

On Thu, Nov 19, 2020 at 11:57:10AM +0100, Oscar Salvador wrote:
> When we want to grab a refcount via get_any_page, we call
> __get_any_page that calls get_hwpoison_page to get the
> actual refcount.
> get_any_page is only there because we have a sort of retry
> mechanism in case the page we met is unknown to us or
> if we raced with an allocation.
> Also __get_any_page prints some messages about the page type
> in case the page was a free page or the page type was unknown,
> but if anything, we only need to print a message in case the
> pagetype was unknown, as that is reporting an error down the chain.
> Let us merge get_any_page and __get_any_page, and let the message
> be printed in soft_offline_page.
> Signed-off-by: Oscar Salvador <>

Looks good to me, thank you.

Acked-by: Naoya Horiguchi <>

Powered by blists - more mailing lists