linux-kernel - Re: [PATCH] mm: memcontrol: account pagetables per node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 21 Nov 2020 12:37:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shakeel Butt <shakeelb@...gle.com>, Roman Gushchin <guro@...com>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...e.com>
Cc:     kbuild-all@...ts.01.org, Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        linux-kernel@...r.kernel.org, Shakeel Butt <shakeelb@...gle.com>
Subject: Re: [PATCH] mm: memcontrol: account pagetables per node

Hi Shakeel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on linus/master v5.10-rc4 next-20201120]
[cannot apply to mmotm/master cgroup/for-next hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shakeel-Butt/mm-memcontrol-account-pagetables-per-node/20201121-102353
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git 33c0c9bdf7a59051a654cd98b7d2b48ce0080967
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/e51fa7d7d401d329238b2f8bc4d506a2ab1f5c67
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shakeel-Butt/mm-memcontrol-account-pagetables-per-node/20201121-102353
        git checkout e51fa7d7d401d329238b2f8bc4d506a2ab1f5c67
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:11,
                    from include/linux/skbuff.h:13,
                    from include/linux/netlink.h:7,
                    from include/uapi/linux/genetlink.h:6,
                    from include/linux/genetlink.h:5,
                    from include/net/genetlink.h:5,
                    from fs/dlm/netlink.c:6:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid'
     143 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   In file included from include/linux/bvec.h:14,
                    from include/linux/skbuff.h:17,
                    from include/linux/netlink.h:7,
                    from include/uapi/linux/genetlink.h:6,
                    from include/linux/genetlink.h:5,
                    from include/net/genetlink.h:5,
                    from fs/dlm/netlink.c:6:
   fs/dlm/netlink.c: At top level:
>> include/linux/mm.h:2201:13: warning: 'inc_lruvec_page_state' used but never defined
    2201 | static void inc_lruvec_page_state(struct page *page, enum node_stat_item idx);
         |             ^~~~~~~~~~~~~~~~~~~~~
>> include/linux/mm.h:2202:13: warning: 'dec_lruvec_page_state' used but never defined
    2202 | static void dec_lruvec_page_state(struct page *page, enum node_stat_item idx);
         |             ^~~~~~~~~~~~~~~~~~~~~
--
   In file included from include/linux/pagemap.h:8,
                    from fs/dlm/debug_fs.c:11:
>> include/linux/mm.h:2201:13: warning: 'inc_lruvec_page_state' used but never defined
    2201 | static void inc_lruvec_page_state(struct page *page, enum node_stat_item idx);
         |             ^~~~~~~~~~~~~~~~~~~~~
>> include/linux/mm.h:2202:13: warning: 'dec_lruvec_page_state' used but never defined
    2202 | static void dec_lruvec_page_state(struct page *page, enum node_stat_item idx);
         |             ^~~~~~~~~~~~~~~~~~~~~

vim +/inc_lruvec_page_state +2201 include/linux/mm.h

  2200	
> 2201	static void inc_lruvec_page_state(struct page *page, enum node_stat_item idx);
> 2202	static void dec_lruvec_page_state(struct page *page, enum node_stat_item idx);
  2203	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (58899 bytes)