linux-kernel - Re: [PATCH] ALSA: emu10k1: Use dma_set_mask_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 21 Nov 2020 09:26:51 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     perex@...ex.cz, tiwai@...e.com, dan.carpenter@...cle.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ALSA: emu10k1: Use dma_set_mask_and_coherent to simplify code

On Sat, 21 Nov 2020 09:16:32 +0100,
Christophe JAILLET wrote:
> 
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.

It's a good cleanup, but ...

> With at it replace the 'card->dev' parameter passed to a 'dev_err()' call
> by an equivalent '&pci->dev' which is more consistent with the test just
> one line above.

... this will make it inconsistent with other error message lines in
the same function, OTOH.  So I don't think this part necessary to be
changed.


thanks,

Takashi