[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <mhng-f056461a-d53c-4405-b514-1d01dba13cc1@palmerdabbelt-glaptop1>
Date: Fri, 20 Nov 2020 16:14:09 -0800 (PST)
From: Palmer Dabbelt <palmerdabbelt@...gle.com>
To: natechancellor@...il.com
CC: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
clang-built-linux@...glegroups.com, natechancellor@...il.com
Subject: Re: [PATCH] riscv: Explicitly specify the build id style in vDSO Makefile again
On Sun, 08 Nov 2020 12:37:37 PST (-0800), natechancellor@...il.com wrote:
> Commit a96843372331 ("kbuild: explicitly specify the build id style")
> explicitly set the build ID style to SHA1. Commit c2c81bb2f691 ("RISC-V:
> Fix the VDSO symbol generaton for binutils-2.35+") undid this change,
> likely unintentionally.
>
> Restore it so that the build ID style stays consistent across the tree
> regardless of linker.
>
> Fixes: c2c81bb2f691 ("RISC-V: Fix the VDSO symbol generaton for binutils-2.35+")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
> arch/riscv/kernel/vdso/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
> index cb8f9e4cfcbf..0cfd6da784f8 100644
> --- a/arch/riscv/kernel/vdso/Makefile
> +++ b/arch/riscv/kernel/vdso/Makefile
> @@ -44,7 +44,7 @@ SYSCFLAGS_vdso.so.dbg = $(c_flags)
> $(obj)/vdso.so.dbg: $(src)/vdso.lds $(obj-vdso) FORCE
> $(call if_changed,vdsold)
> SYSCFLAGS_vdso.so.dbg = -shared -s -Wl,-soname=linux-vdso.so.1 \
> - -Wl,--build-id -Wl,--hash-style=both
> + -Wl,--build-id=sha1 -Wl,--hash-style=both
>
> # We also create a special relocatable object that should mirror the symbol
> # table and layout of the linked DSO. With ld --just-symbols we can then
>
> base-commit: c2c81bb2f69138f902e1a58d3bef6ad97fb8a92c
Sorry about that. This is on fixes.
Powered by blists - more mailing lists