linux-kernel - Re: [PATCH v6] cper, apei, mce: Pass x86 CPER through the MCA handling chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Nov 2020 11:38:02 +0100
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>,
        X86 ML <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-pm@...r.kernel.org, linux-edac@...r.kernel.org,
        linux-efi <linux-efi@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        devel@...ica.org, Tony Luck <tony.luck@...el.com>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>,
        Punit Agrawal <punit1.agrawal@...hiba.co.jp>,
        Yazen Ghannam <yazen.ghannam@....com>
Subject: Re: [PATCH v6] cper, apei, mce: Pass x86 CPER through the MCA
 handling chain

On Sat, 21 Nov 2020 at 11:15, Borislav Petkov <bp@...en8.de> wrote:
>
> On Thu, Nov 19, 2020 at 12:29:38PM -0600, Smita Koralahalli wrote:
> > diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-x86.c
> > index 2531de49f56c..438ed9eff6d0 100644
> > --- a/drivers/firmware/efi/cper-x86.c
> > +++ b/drivers/firmware/efi/cper-x86.c
> > @@ -2,6 +2,7 @@
> >  // Copyright (C) 2018, Advanced Micro Devices, Inc.
> >
> >  #include <linux/cper.h>
> > +#include <linux/acpi.h>
> >
> >  /*
> >   * We don't need a "CPER_IA" prefix since these are all locally defined.
> > @@ -347,9 +348,13 @@ void cper_print_proc_ia(const char *pfx, const struct cper_sec_proc_ia *proc)
> >                              ctx_info->mm_reg_addr);
> >               }
> >
> > -             printk("%sRegister Array:\n", newpfx);
> > -             print_hex_dump(newpfx, "", DUMP_PREFIX_OFFSET, 16, groupsize,
> > -                            (ctx_info + 1), ctx_info->reg_arr_size, 0);
> > +             if (ctx_info->reg_ctx_type != CTX_TYPE_MSR ||
> > +                 arch_apei_report_x86_error(ctx_info, proc->lapic_id)) {
> > +                     printk("%sRegister Array:\n", newpfx);
> > +                     print_hex_dump(newpfx, "", DUMP_PREFIX_OFFSET, 16,
> > +                                    groupsize, (ctx_info + 1),
> > +                                    ctx_info->reg_arr_size, 0);
> > +             }
> >
> >               ctx_info = (struct cper_ia_proc_ctx *)((long)ctx_info + size);
> >       }
> > --
>
> Ard, ack?
>

Acked-by: Ard Biesheuvel <ardb@...nel.org>