linux-kernel - Re: [PATCH] iio: accel: adis16209: remove unneeded spi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 21 Nov 2020 15:40:29 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: accel: adis16209: remove unneeded
 spi_set_drvdata()

On Thu, 19 Nov 2020 16:18:06 +0200
Alexandru Ardelean <alexandru.ardelean@...log.com> wrote:

> There is no matching spi_get_drvdata() in the driver. This looks like a
> left-over from before the driver was converted to device-managed functions.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
Applied

> ---
>  drivers/iio/accel/adis16209.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/adis16209.c b/drivers/iio/accel/adis16209.c
> index 4a841aec6268..6c2d4a967de7 100644
> --- a/drivers/iio/accel/adis16209.c
> +++ b/drivers/iio/accel/adis16209.c
> @@ -279,7 +279,6 @@ static int adis16209_probe(struct spi_device *spi)
>  		return -ENOMEM;
>  
>  	st = iio_priv(indio_dev);
> -	spi_set_drvdata(spi, indio_dev);
>  
>  	indio_dev->name = spi->dev.driver->name;
>  	indio_dev->info = &adis16209_info;