linux-kernel - sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 22 Nov 2020 03:52:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Cezary Rojewski <cezary.rojewski@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Mark Brown <broonie@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn:
 consider using resource_size() here

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   27bba9c532a8d21050b94224ffd310ad0058c353
commit: 6cbfa11d2694b8a1e46d6834fb9705d5589e3ef1 ASoC: Intel: Select catpt and deprecate haswell
date:   7 weeks ago
config: x86_64-randconfig-m001-20201122 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
sound/soc/intel/catpt/loader.c:654 catpt_first_boot_firmware() warn: consider using resource_size() here

vim +654 sound/soc/intel/catpt/loader.c

a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  637  
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  638  int catpt_first_boot_firmware(struct catpt_dev *cdev)
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  639  {
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  640  	struct resource *res;
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  641  	int ret;
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  642  
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  643  	ret = catpt_boot_firmware(cdev, false);
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  644  	if (ret) {
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  645  		dev_err(cdev->dev, "basefw boot failed: %d\n", ret);
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  646  		return ret;
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  647  	}
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  648  
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  649  	/* restrict FW Core dump area */
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  650  	__request_region(&cdev->dram, 0, 0x200, NULL, 0);
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  651  	/* restrict entire area following BASE_FW - highest offset in DRAM */
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  652  	for (res = cdev->dram.child; res->sibling; res = res->sibling)
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29  653  		;
a9aa6fb3eb6c7e Cezary Rojewski 2020-09-29 @654  	__request_region(&cdev->dram, res->end + 1,

:::::: The code at line 654 was first introduced by commit
:::::: a9aa6fb3eb6c7e0e7e117b3f2dfafef8c45b9ea6 ASoC: Intel: catpt: Firmware loading and context restore

:::::: TO: Cezary Rojewski <cezary.rojewski@...el.com>
:::::: CC: Mark Brown <broonie@...nel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (36022 bytes)