linux-kernel - Re: [PATCH v4] fs/aio.c: Cosmetic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Nov 2020 17:22:45 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Alejandro Colomar <alx.manpages@...il.com>,
        Benjamin LaHaise <bcrl@...ck.org>,
        Andreas Dilger <adilger@...ger.ca>,
        Joe Perches <joe@...ches.com>
Cc:     Alejandro Colomar <colomar.6.4.3@...il.com>, linux-aio@...ck.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] fs/aio.c: Cosmetic

On 11/20/20 2:06 PM, Alejandro Colomar wrote:
> Changes:
> - Consistently use 'unsigned int', instead of 'unsigned'.
> - Add a blank line after variable declarations.
> - Move variable declarations to the top of functions.
> - Invert logic of 'if's to reduce indentation and simplify function logic.
> 	- Add goto tags when needed.
> 	- Early return when appropriate.
> - Add braces to 'else' if the corresponding 'if' used braces.
> - Replace spaces by tabs
> - Add spaces when appropriate (after comma, around operators, ...).
> - Split multiple assignments.
> - Align function arguments.
> - Fix typos in comments.
> - s/%Lx/%llx/  Standard C uses 'll'.
> - Remove trailing whitespace in comments.
> 
> This patch does not introduce any actual changes in behavior.
> 
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@...il.com>
> ---
> 
> Hi,
> 
> I rebased the patch on top of the current master,
> to update it after recent changes to aio.c.
> 
> Thanks,
> 
> Alex
> 
>  fs/aio.c | 466 +++++++++++++++++++++++++++++--------------------------
>  1 file changed, 243 insertions(+), 223 deletions(-)

Hi,
I reviewed this patch.
I think it looks OK, but I wish that there was a better way to review it.

I'm not asking you to redo the patch, but I think that it would have been easier
to review 2 patches: one that contains trivial changes[1] and one that requires
thinking to review it -- where the trivial changes are not getting in the way
of looking at the non-trivial changes.

[1] the trivial set of changes, taken from your patch description:

> - Consistently use 'unsigned int', instead of 'unsigned'.
> - Add a blank line after variable declarations.
> - Move variable declarations to the top of functions.
> - Add braces to 'else' if the corresponding 'if' used braces.
> - Replace spaces by tabs
> - Add spaces when appropriate (after comma, around operators, ...).
> - Split multiple assignments.
> - Align function arguments.
> - Fix typos in comments.
> - s/%Lx/%llx/  Standard C uses 'll'.
> - Remove trailing whitespace in comments.

OK, that's everything except for this:
> - Invert logic of 'if's to reduce indentation and simplify function logic.
> 	- Add goto tags when needed.
> 	- Early return when appropriate.


thanks.
-- 
~Randy
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>