lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 22 Nov 2020 16:35:55 +0200
From:   Ido Schimmel <>
To:     Christian Eggers <>
Cc:     Richard Cochran <>,
        Andrew Lunn <>,
        Heiner Kallweit <>,
        Jakub Kicinski <>,
        Vladimir Oltean <>,
        Russell King <>,
        "David S . Miller" <>,,, Christian Eggers <>,
        Petr Machata <>,
        Jiri Pirko <>, Ido Schimmel <>
Subject: Re: [PATCH net-next 2/3] mlxsw: spectrum_ptp: use PTP wide message
 type definitions

On Sun, Nov 22, 2020 at 09:26:35AM +0100, Christian Eggers wrote:
> Use recently introduced PTP wide defines instead of a driver internal
> enumeration.
> Signed-off-by: Christian Eggers <>
> Cc: Petr Machata <>
> Cc: Jiri Pirko <>
> Cc: Ido Schimmel <>

Reviewed-by: Ido Schimmel <>


1. Checkpatch complains about:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Christian Eggers <>' != 'Signed-off-by: Christian Eggers <>'

2. This series does not build, which fails the CI [1][2] and also
required me to fetch the dependencies that are currently under review
[3]. I believe it is generally discouraged to create dependencies
between patch sets that are under review for exactly these reasons. I
don't know what are Jakub's preferences, but had this happened on our
internal patchwork instance, I would just ask the author to submit
another version with all the patches.

Anyway, I added all six patches to our regression as we have some PTP
tests. Will let you know tomorrow.



Powered by blists - more mailing lists