lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 Nov 2020 16:18:10 -0800 From: Moritz Fischer <mdf@...nel.org> To: David Gow <davidgow@...gle.com> Cc: Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>, linux-fpga@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-um <linux-um@...ts.infradead.org>, Brendan Higgins <brendanhiggins@...gle.com> Subject: Re: [PATCH v2] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL On Fri, Nov 20, 2020 at 03:46:48PM -0800, David Gow wrote: > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' > functions, it should depend on HAS_IOMEM. > > This fixes make allyesconfig under UML (ARCH=um), which doesn't provide > HAS_IOMEM. > > Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers") > Signed-off-by: David Gow <davidgow@...gle.com> > --- > > Changes since v1: > ( https://lore.kernel.org/linux-fpga/20201119082209.3598354-1-davidgow@google.com/ ) > - Add Fixes tag > > drivers/fpga/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 7cd5a29fc437..5645226ca3ce 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -142,6 +142,7 @@ config FPGA_DFL > tristate "FPGA Device Feature List (DFL) support" > select FPGA_BRIDGE > select FPGA_REGION > + depends on HAS_IOMEM > help > Device Feature List (DFL) defines a feature list structure that > creates a linked list of feature headers within the MMIO space > -- > 2.29.2.454.gaff20da3a2-goog > Applied to for-5.10, I fixed up your commit message (dropped the drivers:) - Moritz
Powered by blists - more mailing lists