linux-kernel - Re: [PATCH 1/1] pinctrl: add IRQF_EARLY_RESUME flags with gpio irq for elan touchpad.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e67c040-2aff-65bd-188a-bacf9a7fd7c4@redhat.com>
Date:   Mon, 23 Nov 2020 13:46:50 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>,
        caizhaopeng@...ontech.com
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andy@...nel.org>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Zhangyueqian <zhangyueqian@...ontech.com>,
        Zhangshuang <zhangshuang@...ontech.com>,
        Hualet Wang <wangyaohua@...ontech.com>,
        Zhanglei <zhanglei@...ontech.com>
Subject: Re: [PATCH 1/1] pinctrl: add IRQF_EARLY_RESUME flags with gpio irq
 for elan touchpad.

Hi,

On 11/12/20 2:52 PM, Andy Shevchenko wrote:
> 
> +Cc: Hans.
> 
> I can't speak for AMD, but I think it may be useful for Intel pin control.
> However, I didn't check what may be the side effects of this change and neither
> contributor answered to my comments...

AFAICT setting IRQF_EARLY_RESUME causes it to not be resumed during
normal IRQ resuming, but earlier during the syscore_resume() call.

There are 2 problems with this:

1. When using S3 suspend syscore_resume() runs before any device
suspend handlers, so any state restoring which the GPIO controller's
resume handler is doing has not been done yet. While esp. after
S3 suspend the restoring may be important (s2idle suspend should
not touch the GPIO registers contents).

2. When using S2idle suspend syscore_resume() *never* runs, and
IRQs marked with IRQF_EARLY_RESUME are skipped during the normal
IRQ resume phase, so these IRQs will never be resumed.

Also IRQF_EARLY_RESUME is used almost no where:

[hans@x1 linux]$ ack -l IRQF_EARLY_RESUME drivers
drivers/xen/events/events_base.c
drivers/rtc/rtc-sc27xx.c
drivers/mfd/twl4030-irq.c

Which is probably why we have not yet hit the s2idle issue with it.

So this all in all seems like a bad idea, and we need to better root
cause the issue with these Elan touchpads and fix the actual issue.

Regards,

Hans




> 
> So, just heads up.
> 
> On Fri, Apr 24, 2020 at 05:12:01PM +0800, caizhaopeng@...ontech.com wrote:
>> From: Caicai <caizhaopeng@...ontech.com>
>>
>> I had tested two Notebook machines, the Intel i5(or amd ryzen)
>> with elan touchpad, and there's a probability that the touchpad
>> won't work after going to the S3/S4 to wake up, that it would
>> appear no more than 15 times. I found that there's no interrupt
>> to check for /proc/interrupt. It was found that the gpio
>> interrupt of i2c was also not on top. By adding the gpio
>> interrupt flags with IRQF_EARLY_RESUME, now the touchpad tested
>> 200 + times works well.
>>
>> Signed-off-by: Caicai <caizhaopeng@...ontech.com>
>> ---
>>  drivers/pinctrl/intel/pinctrl-intel.c | 2 +-
>>  drivers/pinctrl/pinctrl-amd.c         | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
>> index 8fb6c9668c37..a350dade6aa0 100644
>> --- a/drivers/pinctrl/intel/pinctrl-intel.c
>> +++ b/drivers/pinctrl/intel/pinctrl-intel.c
>> @@ -1189,7 +1189,7 @@ static int intel_gpio_probe(struct intel_pinctrl *pctrl, int irq)
>>  	 * controllers share the same interrupt line.
>>  	 */
>>  	ret = devm_request_irq(pctrl->dev, irq, intel_gpio_irq,
>> -			       IRQF_SHARED | IRQF_NO_THREAD,
>> +			       IRQF_SHARED | IRQF_NO_THREAD | IRQF_EARLY_RESUME,
>>  			       dev_name(pctrl->dev), pctrl);
>>  	if (ret) {
>>  		dev_err(pctrl->dev, "failed to request interrupt\n");
>> diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
>> index 977792654e01..70c37f4da2b1 100644
>> --- a/drivers/pinctrl/pinctrl-amd.c
>> +++ b/drivers/pinctrl/pinctrl-amd.c
>> @@ -937,7 +937,7 @@ static int amd_gpio_probe(struct platform_device *pdev)
>>  	}
>>  
>>  	ret = devm_request_irq(&pdev->dev, irq_base, amd_gpio_irq_handler,
>> -			       IRQF_SHARED, KBUILD_MODNAME, gpio_dev);
>> +			       IRQF_SHARED | IRQF_EARLY_RESUME | IRQF_NO_THREAD, KBUILD_MODNAME, gpio_dev);
>>  	if (ret)
>>  		goto out2;
>>  
>> -- 
>> 2.20.1
>>
>>
>>
>