[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d8812dd1-1912-edac-d2a7-eb2462ab1923@samsung.com>
Date: Mon, 23 Nov 2020 14:12:05 +0900
From: Chanwoo Choi <cw00.choi@...sung.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 09/16] mfd: max77686: drop of_match_ptr from
of_device_id table
Hi Krzysztof,
On 11/21/20 1:21 AM, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here). This fixes
> compile warning (!CONFIG_OF on x86_64):
>
> drivers/mfd/max77686.c:148:34: warning: ‘max77686_pmic_dt_match’ defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
> drivers/mfd/max77686.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 71faf503844b..2ad554b921d9 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -270,7 +270,7 @@ static struct i2c_driver max77686_i2c_driver = {
> .driver = {
> .name = "max77686",
> .pm = &max77686_pm,
> - .of_match_table = of_match_ptr(max77686_pmic_dt_match),
> + .of_match_table = max77686_pmic_dt_match,
> },
> .probe_new = max77686_i2c_probe,
> };
>
Acked-by: Chanwoo Choi <cw00.choi@...sung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Powered by blists - more mailing lists