linux-kernel - [PATCH] firmware: arm_scmi: remove residual

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Nov 2020 16:20:08 +0000
From:   Cristian Marussi <cristian.marussi@....com>
To:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     sudeep.holla@....com, Cristian Marussi <cristian.marussi@....com>
Subject: [PATCH] firmware: arm_scmi: remove residual _le structs naming

For sake of consistency, remove any residual naming based on _le suffixes
in SCMI Sensors Protocol, since little endianity is already assumed across
all of SCMI implementation and, as such, all currently existent names do
not explicitly state their endianness.

No functional change.

Signed-off-by: Cristian Marussi <cristian.marussi@....com>
---
Based on for-next/scmi

commit e3811190acf8 ("firmware: arm_scmi: Add SCMI v3.0 sensor notifications")

Thanks

Cristian
---
 drivers/firmware/arm_scmi/sensors.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c
index b3d7c08c09a0..4541b891b733 100644
--- a/drivers/firmware/arm_scmi/sensors.c
+++ b/drivers/firmware/arm_scmi/sensors.c
@@ -168,7 +168,7 @@ struct scmi_resp_sensor_reading_complete {
 	__le64 readings;
 };
 
-struct scmi_sensor_reading_le {
+struct scmi_sensor_reading_resp {
 	__le32 sensor_value_low;
 	__le32 sensor_value_high;
 	__le32 timestamp_low;
@@ -177,7 +177,7 @@ struct scmi_sensor_reading_le {
 
 struct scmi_resp_sensor_reading_complete_v3 {
 	__le32 id;
-	struct scmi_sensor_reading_le readings[];
+	struct scmi_sensor_reading_resp readings[];
 };
 
 struct scmi_sensor_trip_notify_payld {
@@ -189,7 +189,7 @@ struct scmi_sensor_trip_notify_payld {
 struct scmi_sensor_update_notify_payld {
 	__le32 agent_id;
 	__le32 sensor_id;
-	struct scmi_sensor_reading_le readings[];
+	struct scmi_sensor_reading_resp readings[];
 };
 
 struct sensors_info {
@@ -734,7 +734,7 @@ static int scmi_sensor_reading_get(const struct scmi_handle *handle,
 
 static inline void
 scmi_parse_sensor_readings(struct scmi_sensor_reading *out,
-			   const struct scmi_sensor_reading_le *in)
+			   const struct scmi_sensor_reading_resp *in)
 {
 	out->value = get_unaligned_le64((void *)&in->sensor_value_low);
 	out->timestamp = get_unaligned_le64((void *)&in->timestamp_low);
@@ -797,7 +797,7 @@ scmi_sensor_reading_get_timestamped(const struct scmi_handle *handle,
 		ret = scmi_do_xfer(handle, t);
 		if (!ret) {
 			int i;
-			struct scmi_sensor_reading_le *resp_readings;
+			struct scmi_sensor_reading_resp *resp_readings;
 
 			resp_readings = t->rx.buf;
 			for (i = 0; i < count; i++)
@@ -931,7 +931,7 @@ static const struct scmi_event sensor_events[] = {
 		.max_payld_sz =
 			sizeof(struct scmi_sensor_update_notify_payld) +
 			 SCMI_MAX_NUM_SENSOR_AXIS *
-			 sizeof(struct scmi_sensor_reading_le),
+			 sizeof(struct scmi_sensor_reading_resp),
 		.max_report_sz = sizeof(struct scmi_sensor_update_report) +
 				  SCMI_MAX_NUM_SENSOR_AXIS *
 				  sizeof(struct scmi_sensor_reading),
-- 
2.17.1