linux-kernel - Re: [PATCH 1/2] mmc: sdhci-sprd: drop of_match_ptr from of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAfSe-viA0PqAjNcvbC8JgngVcDc1+06FqGtKAdaPT1ur7kHTQ@mail.gmail.com>
Date:   Mon, 23 Nov 2020 13:36:25 +0800
From:   Chunyan Zhang <zhang.lyra@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Patrice Chotard <patrice.chotard@...com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/2] mmc: sdhci-sprd: drop of_match_ptr from of_device_id table

On Sat, 21 Nov 2020 at 00:23, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here).  This fixes
> compile warning (!CONFIG_OF on x86_64):
>
>     drivers/mmc/host/sdhci-sprd.c:723:34: warning:
>         ‘sdhci_sprd_of_match’ defined but not used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Acked-by: Chunyan Zhang <zhang.lyra@...il.com>

> ---
>  drivers/mmc/host/sdhci-sprd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 58109c5b53e2..f85171edabeb 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -788,7 +788,7 @@ static struct platform_driver sdhci_sprd_driver = {
>         .driver = {
>                 .name = "sdhci_sprd_r11",
>                 .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> -               .of_match_table = of_match_ptr(sdhci_sprd_of_match),
> +               .of_match_table = sdhci_sprd_of_match,
>                 .pm = &sdhci_sprd_pm_ops,
>         },
>  };
> --
> 2.25.1
>