linux-kernel - Re: [PATCH 0/2] Remove one more platform_device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201123173603.GJ4077@smile.fi.intel.com>
Date:   Mon, 23 Nov 2020 19:36:03 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Felipe Balbi <balbi@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:ULTRA-WIDEBAND (UWB) SUBSYSTEM:" 
        <linux-usb@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH 0/2] Remove one more platform_device_add_properties() call

On Mon, Nov 23, 2020 at 06:06:31PM +0100, Rafael J. Wysocki wrote:
> On Mon, Nov 23, 2020 at 4:32 PM Heikki Krogerus
> <heikki.krogerus@...ux.intel.com> wrote:
> >
> > Hi,
> >
> > I originally introduced these as part of my series where I was
> > proposing PM ops for software nodes [1], but since that still needs
> > work, I'm sending these two separately.
> >
> > So basically I'm only modifying dwc3-pci.c so it registers a software
> > node directly at this point. That will remove one more user of
> > platform_device_add_properties().
> >
> > [1] https://lore.kernel.org/lkml/20201029105941.63410-1-heikki.krogerus@linux.intel.com/
> >
> > thanks,
> >
> > Heikki Krogerus (2):
> >   software node: Introduce device_add_software_node()
> >   usb: dwc3: pci: Register a software node for the dwc3 platform device
> >
> >  drivers/base/swnode.c       | 69 ++++++++++++++++++++++++++++++++-----
> >  drivers/usb/dwc3/dwc3-pci.c | 61 +++++++++++++++++++-------------
> >  include/linux/property.h    |  3 ++
> >  3 files changed, 100 insertions(+), 33 deletions(-)
> >
> > --
> 
> These look good to me.
> 
> If you want me to take them, though, I need an ACK from the dwc3 side.

Btw, I have tested this on one of the platform with DWC3 and found no
regression, so feel free to add

Tested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

-- 
With Best Regards,
Andy Shevchenko