linux-kernel - Re: [RFC PATCH] regmap: remove duplicate `type` field from `regcache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201123181038.GN6322@sirena.org.uk>
Date:   Mon, 23 Nov 2020 18:10:38 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Philippe Duplessis-Guindon <pduplessis@...icios.com>
Cc:     linux-trace-devel@...r.kernel.org,
        Steven Rostedt <rostedt@...dmis.org>,
        mathieu.desnoyers@...icios.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] regmap: remove duplicate `type` field from
 `regcache_sync` trace event

On Mon, Nov 23, 2020 at 11:15:19AM -0500, Philippe Duplessis-Guindon wrote:

> 	$ sudo cat /sys/kernel/debug/tracing/events/regmap/regcache_sync/format
> 	name: regcache_sync
> 	ID: 1216
> 	format:

These dumps are very large, don't fit within 80 columns and it's quite
hard to figure out information they are intended to convey so they make
it quite hard to read your commit message.  Please just remove them if
they can't be made clear, I think the text is enough.

> 		field:__data_loc char[] type;	offset:16;	size:4;	signed:1;
> 		field:int type;    offset:20;    size:4;    signed:1;

> Erase the `int field` type, who was not assigned. This field was introduce by mistake and this commit removes it.

Please word wrap your commit message at less than 80 columns.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)