linux-kernel - Re: [PATCH] zlib: export S390 symbols for zlib modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48fe521ac710f6a4d5e85a81109ef41f16dd2550.camel@linux.ibm.com>
Date:   Mon, 23 Nov 2020 20:20:38 +0100
From:   Ilya Leoshkevich <iii@...ux.ibm.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>,
        Mikhail Zaslonko <zaslonko@...ux.ibm.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH] zlib: export S390 symbols for zlib modules

On Mon, 2020-11-23 at 11:17 -0800, Randy Dunlap wrote:
> Fix build errors when ZLIB_INFLATE=m and ZLIB_DEFLATE=m
> and ZLIB_DFLTCC=y by exporting the 2 needed symbols in
> dfltcc_inflate.c.
> 
> Fixes these build errors:
> 
> ERROR: modpost: "dfltcc_inflate" [lib/zlib_inflate/zlib_inflate.ko]
> undefined!
> ERROR: modpost: "dfltcc_can_inflate"
> [lib/zlib_inflate/zlib_inflate.ko] undefined!
> 
> Fixes: 126196100063 ("lib/zlib: add s390 hardware support for kernel
> zlib_inflate")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Mikhail Zaslonko <zaslonko@...ux.ibm.com>
> Cc: Ilya Leoshkevich <iii@...ux.ibm.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: linux-s390@...r.kernel.org
> ---
>  lib/zlib_dfltcc/dfltcc_inflate.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- linux-next-20201120.orig/lib/zlib_dfltcc/dfltcc_inflate.c
> +++ linux-next-20201120/lib/zlib_dfltcc/dfltcc_inflate.c
> @@ -4,6 +4,7 @@
>  #include "dfltcc_util.h"
>  #include "dfltcc.h"
>  #include <asm/setup.h>
> +#include <linux/export.h>
>  #include <linux/zutil.h>
>  
>  /*
> @@ -29,6 +30,7 @@ int dfltcc_can_inflate(
>      return is_bit_set(dfltcc_state->af.fns, DFLTCC_XPND) &&
>                 is_bit_set(dfltcc_state->af.fmts, DFLTCC_FMT0);
>  }
> +EXPORT_SYMBOL(dfltcc_can_inflate);
>  
>  static int dfltcc_was_inflate_used(
>      z_streamp strm
> @@ -147,3 +149,4 @@ dfltcc_inflate_action dfltcc_inflate(
>      return (cc == DFLTCC_CC_OP1_TOO_SHORT || cc ==
> DFLTCC_CC_OP2_TOO_SHORT) ?
>          DFLTCC_INFLATE_BREAK : DFLTCC_INFLATE_CONTINUE;
>  }
> +EXPORT_SYMBOL(dfltcc_inflate);

Thanks for fixing this!

Acked-by: Ilya Leoshkevich <iii@...ux.ibm.com>