linux-kernel - Re: [PATCH 1/3] serial: 8250: of: Check for CONFIG_SERIAL_8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Nov 2020 15:14:43 -0500
From:   Jim Quinlan <james.quinlan@...adcom.com>
To:     Al Cooper <alcooperx@...il.com>
Cc:     open list <linux-kernel@...r.kernel.org>,
        Jim Quinlan <jquinlan@...adcom.com>,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" 
        <devicetree@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-serial@...r.kernel.org,
        "open list:USB SUBSYSTEM" <linux-usb@...r.kernel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH 1/3] serial: 8250: of: Check for CONFIG_SERIAL_8250_BCM7271

On Mon, Nov 23, 2020 at 10:58 AM Jim Quinlan <james.quinlan@...adcom.com> wrote:
>
> On Fri, Nov 20, 2020 at 2:45 PM Al Cooper <alcooperx@...il.com> wrote:
> >
> > From: Jim Quinlan <jquinlan@...adcom.com>
> >
> > This commit has of_platform_serial_probe() check specifically for the
> > "brcm,bcm7271-uart" and whether its companion driver is enabled. If it
> > is the case, and the clock provider is not ready, we want to make sure
> > that when the 8250_bcm7271.c driver returns EPROBE_DEFER, we are not
> > getting the UART registered via 8250_of.c.
> >
> > Signed-off-by: Jim Quinlan <jquinlan@...adcom.com>
> > ---
> >  drivers/tty/serial/8250/8250_of.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
> > index 65e9045dafe6..aa458f3c6644 100644
> > --- a/drivers/tty/serial/8250/8250_of.c
> > +++ b/drivers/tty/serial/8250/8250_of.c
> > @@ -192,6 +192,10 @@ static int of_platform_serial_probe(struct platform_device *ofdev)
> >         u32 tx_threshold;
> >         int ret;
> >
> > +       if (IS_ENABLED(CONFIG_SERIAL_8250_BCM7271) &&
> > +           of_device_is_compatible(ofdev->dev.of_node, "brcm,bcm7271-uart"))
> > +               return -ENODEV;
> > +
> NOTE: this commit is a "strawman" commit, and I will not be surprised
> if it gets quickly NAKed. We have a new idea on how to solve this
> issue, and if that not is not viable, will ask for a dialog on this
> problem either in this thread or through a separate RFC.


This commit is no longer needed  as part of this patchset; we have
addressed the problem elsewhere.  Sorry about the noise.
>
>
> Regards,
> Jim Quinlan
> Broadcom STB
>
>
>
> >         port_type = (unsigned long)of_device_get_match_data(&ofdev->dev);
> >         if (port_type == PORT_UNKNOWN)
> >                 return -EINVAL;
> > --
> > 2.17.1
> >

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4167 bytes)