linux-kernel - Re: [Freedreno] [PATCH 11/40] drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra param description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd9e7b914116e49b60b082fe40daf78c@codeaurora.org>
Date:   Mon, 23 Nov 2020 13:06:49 -0800
From:   abhinavk@...eaurora.org
To:     Lee Jones <lee.jones@...aro.org>
Cc:     freedreno@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, Rob Clark <robdclark@...il.com>,
        Daniel Vetter <daniel@...ll.ch>, Sean Paul <sean@...rly.run>
Subject: Re: [Freedreno] [PATCH 11/40] drm/msm/disp/dpu1/dpu_hw_blk: Add one
 missing and remove an extra param description

On 2020-11-23 03:18, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c:28: warning: Function
> parameter or member 'hw_blk' not described in 'dpu_hw_blk_init'
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c:120: warning: Excess
> function parameter 'free_blk' description in 'dpu_hw_blk_put'
> 
> Cc: Rob Clark <robdclark@...il.com>
> Cc: Sean Paul <sean@...rly.run>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: freedreno@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Reviewed-by: Abhinav Kumar <abhinavk@...eaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
> index ca26666d2af91..819b26e660b9c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c
> @@ -19,6 +19,7 @@ static LIST_HEAD(dpu_hw_blk_list);
> 
>  /**
>   * dpu_hw_blk_init - initialize hw block object
> + * @hw_blk: pointer to hw block object
>   * @type: hw block type - enum dpu_hw_blk_type
>   * @id: instance id of the hw block
>   * @ops: Pointer to block operations
> @@ -114,7 +115,6 @@ struct dpu_hw_blk *dpu_hw_blk_get(struct
> dpu_hw_blk *hw_blk, u32 type, int id)
>  /**
>   * dpu_hw_blk_put - put hw_blk to free pool if decremented refcount is 
> zero
>   * @hw_blk: hw block to be freed
> - * @free_blk: function to be called when reference count goes to zero
>   */
>  void dpu_hw_blk_put(struct dpu_hw_blk *hw_blk)
>  {