linux-kernel - Re: [Freedreno] [PATCH 31/40] drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply 'global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04c43a8bf76d7d44fb21add18697f470@codeaurora.org>
Date:   Mon, 23 Nov 2020 13:13:33 -0800
From:   abhinavk@...eaurora.org
To:     Lee Jones <lee.jones@...aro.org>
Cc:     freedreno@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, Rob Clark <robdclark@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Drew Davenport <ddavenport@...omium.org>,
        Sean Paul <sean@...rly.run>
Subject: Re: [Freedreno] [PATCH 31/40] drm/msm/disp/dpu1/dpu_rm: Fix
 formatting issues and supply 'global_state' description

On 2020-11-23 03:19, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:247: warning: Excess function
> parameter 'Return' description in '_dpu_rm_check_lm_peer'
>  drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Function
> parameter or member 'global_state' not described in
> '_dpu_rm_check_lm_and_get_connected_blks'
>  drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c:283: warning: Excess function
> parameter 'Return' description in
> '_dpu_rm_check_lm_and_get_connected_blks'
> 
> Cc: Rob Clark <robdclark@...il.com>
> Cc: Sean Paul <sean@...rly.run>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Drew Davenport <ddavenport@...omium.org>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: freedreno@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Reviewed-by: Abhinav Kumar <abhinavk@...eaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> index 0ae8a36ffcff3..fd2d104f0a91d 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> @@ -239,7 +239,7 @@ static bool _dpu_rm_needs_split_display(const
> struct msm_display_topology *top)
>   * @rm: dpu resource manager handle
>   * @primary_idx: index of primary mixer in rm->mixer_blks[]
>   * @peer_idx: index of other mixer in rm->mixer_blks[]
> - * @Return: true if rm->mixer_blks[peer_idx] is a peer of
> + * Return: true if rm->mixer_blks[peer_idx] is a peer of
>   *          rm->mixer_blks[primary_idx]
>   */
>  static bool _dpu_rm_check_lm_peer(struct dpu_rm *rm, int primary_idx,
> @@ -264,6 +264,7 @@ static bool _dpu_rm_check_lm_peer(struct dpu_rm
> *rm, int primary_idx,
>   *	proposed use case requirements, incl. hardwired dependent blocks 
> like
>   *	pingpong
>   * @rm: dpu resource manager handle
> + * @global_state: resources shared across multiple kms objects
>   * @enc_id: encoder id requesting for allocation
>   * @lm_idx: index of proposed layer mixer in rm->mixer_blks[], 
> function checks
>   *      if lm, and all other hardwired blocks connected to the lm (pp) 
> is
> @@ -274,7 +275,7 @@ static bool _dpu_rm_check_lm_peer(struct dpu_rm
> *rm, int primary_idx,
>   *      mixer in rm->dspp_blks[].
>   * @reqs: input parameter, rm requirements for HW blocks needed in the
>   *      datapath.
> - * @Return: true if lm matches all requirements, false otherwise
> + * Return: true if lm matches all requirements, false otherwise
>   */
>  static bool _dpu_rm_check_lm_and_get_connected_blks(struct dpu_rm *rm,
>  		struct dpu_global_state *global_state,