linux-kernel - Re: [PATCH 22/24] perf buildid-cache: Add --debuginfod option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201123222659.GA2088148@krava>
Date:   Mon, 23 Nov 2020 23:26:59 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Michael Petlan <mpetlan@...hat.com>,
        Song Liu <songliubraving@...com>,
        Stephane Eranian <eranian@...gle.com>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH 22/24] perf buildid-cache: Add --debuginfod option

On Thu, Nov 19, 2020 at 12:23:53PM -0800, Ian Rogers wrote:
> On Mon, Nov 9, 2020 at 1:55 PM Jiri Olsa <jolsa@...nel.org> wrote:
> 
> > Adding --debuginfod option to specify debuginfod url and
> > support to do that through config file as well.
> >
> > Use following in ~/.perfconfig file:
> >
> >   [buildid-cache]
> >   debuginfod=http://192.168.122.174:8002
> >
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> > ---
> >  .../perf/Documentation/perf-buildid-cache.txt |  4 +++
> >  tools/perf/builtin-buildid-cache.c            | 28 +++++++++++++++++--
> >  2 files changed, 29 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/perf/Documentation/perf-buildid-cache.txt
> > b/tools/perf/Documentation/perf-buildid-cache.txt
> > index b77da5138bca..0152d8b5cfbe 100644
> > --- a/tools/perf/Documentation/perf-buildid-cache.txt
> > +++ b/tools/perf/Documentation/perf-buildid-cache.txt
> > @@ -84,6 +84,10 @@ OPTIONS
> >         used when creating a uprobe for a process that resides in a
> >         different mount namespace from the perf(1) utility.
> >
> > +--debuginfod=URL::
> > +       Specify debuginfod URL to be used when retrieving perf.data
> > binaries,
> > +       it follows the same syntax as the DEBUGINFOD_URLS variable.
> > +
> >
> 
> Acked-by: Ian Rogers <irogers@...gle.com>
> 
> Nit: the environment variable name hints at this being a list, perhaps
> change URL:: above to URLs:: to keep this clear.

true, will change that

thanks,
jirka