linux-kernel - Re: [Regression]: Commit 74d905d2 breaks the touchpad and touchscreen of Google Chromebook "samus"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdb4+av1sDrQHYXYeyKemnm2a9PFGQbu++UHEe6sspRACQ@mail.gmail.com>
Date:   Tue, 24 Nov 2020 00:27:02 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andre <andre.muller@....de>
Cc:     Nick Dyer <nick.dyer@...ev.co.uk>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "George G. Davis" <george_davis@...tor.com>,
        Jiada Wang <jiada_wang@...tor.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Regression]: Commit 74d905d2 breaks the touchpad and touchscreen
 of Google Chromebook "samus"

On Wed, Nov 4, 2020 at 9:18 AM Andre <andre.muller@....de> wrote:

> commit 74d905d2: Input: atmel_mxt_ts - only read messages in
> mxt_acquire_irq() when necessary
>
> breaks the touchpad and touchscreen of the 2015 Chromebook Pixel "Samus".

This commit also breaks the touchscreen on the Samsung GT-I9070
mobile phone. All interrupts stop appearing. If I revert the patch
I get interrupts.

dmesg after this commit:

$ dmesg |grep mxt
[    1.967816] atmel_mxt_ts 3-004a: Family: 129 Variant: 1 Firmware
V1.0.AA Objects: 18
[    1.975815] atmel_mxt_ts 3-004a: Enabling RETRIGEN workaround
[    1.982398] atmel_mxt_ts 3-004a: Direct firmware load for
maxtouch.cfg failed with error -2
[    1.992252] atmel_mxt_ts 3-004a: Touchscreen size X479Y799

dmesg with commit reverted:
$ dmesg |grep mxt
[    1.967831] atmel_mxt_ts 3-004a: Family: 129 Variant: 1 Firmware
V1.0.AA Objects: 18
[    1.984195] atmel_mxt_ts 3-004a: Direct firmware load for
maxtouch.cfg failed with error -2
[    2.007399] atmel_mxt_ts 3-004a: Touchscreen size X479Y799

And I get interrupts.

Tell me if I need to test some more approaches.

Yours,
Linus Walleij