linux-kernel - Re: [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9917F51E-C0C5-45AA-903A-DA3C10398F95@holtmann.org>
Date:   Mon, 23 Nov 2020 12:51:48 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>, matthias.bgg@...il.com,
        Mark-YW.Chen@...iatek.com, sean.wang@...iatek.com,
        linux-bluetooth@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btmtksdio: Add the missed release_firmware()
 in mtk_setup_firmware()

Hi Jing,

> mtk_setup_firmware() misses to call release_firmware() in an error
> path. Jump to free_fw to fix it.
> 
> Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
> ---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel