lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Nov 2020 10:53:56 -0500 From: Alex Deucher <alexdeucher@...il.com> To: Lee Jones <lee.jones@...aro.org> Cc: David Airlie <airlied@...ux.ie>, LKML <linux-kernel@...r.kernel.org>, amd-gfx list <amd-gfx@...ts.freedesktop.org>, Maling list - DRI developers <dri-devel@...ts.freedesktop.org>, Alex Deucher <alexander.deucher@....com>, Christian König <christian.koenig@....com> Subject: Re: [PATCH 04/40] drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot misnaming issue On Mon, Nov 23, 2020 at 6:20 AM Lee Jones <lee.jones@...aro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:115: warning: Function parameter or member 'adev' not described in 'amdgpu_virt_request_full_gpu' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:115: warning: Excess function parameter 'amdgpu' description in 'amdgpu_virt_request_full_gpu' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:138: warning: Function parameter or member 'adev' not described in 'amdgpu_virt_release_full_gpu' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:138: warning: Excess function parameter 'amdgpu' description in 'amdgpu_virt_release_full_gpu' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:159: warning: Function parameter or member 'adev' not described in 'amdgpu_virt_reset_gpu' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:159: warning: Excess function parameter 'amdgpu' description in 'amdgpu_virt_reset_gpu' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:194: warning: Function parameter or member 'adev' not described in 'amdgpu_virt_wait_reset' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:194: warning: Excess function parameter 'amdgpu' description in 'amdgpu_virt_wait_reset' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:210: warning: Function parameter or member 'adev' not described in 'amdgpu_virt_alloc_mm_table' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:210: warning: Excess function parameter 'amdgpu' description in 'amdgpu_virt_alloc_mm_table' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:239: warning: Function parameter or member 'adev' not described in 'amdgpu_virt_free_mm_table' > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:239: warning: Excess function parameter 'amdgpu' description in 'amdgpu_virt_free_mm_table' > > Cc: Alex Deucher <alexander.deucher@....com> > Cc: "Christian König" <christian.koenig@....com> > Cc: David Airlie <airlied@...ux.ie> > Cc: Daniel Vetter <daniel@...ll.ch> > Cc: amd-gfx@...ts.freedesktop.org > Cc: dri-devel@...ts.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@...aro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > index 905b85391e64a..462c5dd8ca72c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > @@ -106,7 +106,7 @@ void amdgpu_virt_kiq_reg_write_reg_wait(struct amdgpu_device *adev, > > /** > * amdgpu_virt_request_full_gpu() - request full gpu access > - * @amdgpu: amdgpu device. > + * @adev: amdgpu device. > * @init: is driver init time. > * When start to init/fini driver, first need to request full gpu access. > * Return: Zero if request success, otherwise will return error. > @@ -129,7 +129,7 @@ int amdgpu_virt_request_full_gpu(struct amdgpu_device *adev, bool init) > > /** > * amdgpu_virt_release_full_gpu() - release full gpu access > - * @amdgpu: amdgpu device. > + * @adev: amdgpu device. > * @init: is driver init time. > * When finishing driver init/fini, need to release full gpu access. > * Return: Zero if release success, otherwise will returen error. > @@ -151,7 +151,7 @@ int amdgpu_virt_release_full_gpu(struct amdgpu_device *adev, bool init) > > /** > * amdgpu_virt_reset_gpu() - reset gpu > - * @amdgpu: amdgpu device. > + * @adev: amdgpu device. > * Send reset command to GPU hypervisor to reset GPU that VM is using > * Return: Zero if reset success, otherwise will return error. > */ > @@ -186,7 +186,7 @@ void amdgpu_virt_request_init_data(struct amdgpu_device *adev) > > /** > * amdgpu_virt_wait_reset() - wait for reset gpu completed > - * @amdgpu: amdgpu device. > + * @adev: amdgpu device. > * Wait for GPU reset completed. > * Return: Zero if reset success, otherwise will return error. > */ > @@ -202,7 +202,7 @@ int amdgpu_virt_wait_reset(struct amdgpu_device *adev) > > /** > * amdgpu_virt_alloc_mm_table() - alloc memory for mm table > - * @amdgpu: amdgpu device. > + * @adev: amdgpu device. > * MM table is used by UVD and VCE for its initialization > * Return: Zero if allocate success. > */ > @@ -232,7 +232,7 @@ int amdgpu_virt_alloc_mm_table(struct amdgpu_device *adev) > > /** > * amdgpu_virt_free_mm_table() - free mm table memory > - * @amdgpu: amdgpu device. > + * @adev: amdgpu device. > * Free MM table memory > */ > void amdgpu_virt_free_mm_table(struct amdgpu_device *adev) > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@...ts.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists