linux-kernel - Re: [PATCH] trace: fix potenial dangerous pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X70+Ll+L2ksoeCMv@mtj.duckdns.org>
Date:   Tue, 24 Nov 2020 12:09:02 -0500
From:   Tejun Heo <tj@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Hui Su <sh_def@....com>, mingo@...hat.com, jack@...e.cz,
        akpm@...ux-foundation.org, neilb@...e.de,
        trond.myklebust@...merspace.com, liuzhiqiang26@...wei.com,
        tytso@....edu, cai@....pw, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace: fix potenial dangerous pointer

On Tue, Nov 24, 2020 at 12:05:23PM -0500, Steven Rostedt wrote:
> On Wed, 25 Nov 2020 00:52:05 +0800
> Hui Su <sh_def@....com> wrote:
> 
> > The bdi_dev_name() returns a char [64], and
> > the __entry->name is a char [32].
> > 
> > It maybe dangerous to TP_printk("%s", __entry->name)
> > after the strncpy().
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> 
> This should go through the tree that has the code that uses these
> tracepoints.

Acked-by: Tejun Heo <tj@...nel.org>

Andrew, can you please route this one?

Thanks.

-- 
tejun