linux-kernel - Re: [PATCH V2] PM / EM: Micro optimization in em_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <671427cc-2abb-68eb-5e54-0851785efa84@intel.com>
Date:   Tue, 24 Nov 2020 18:15:33 +0100
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     Pavankumar Kondeti <pkondeti@...eaurora.org>,
        linux-kernel@...r.kernel.org
Cc:     Lukasz Luba <lukasz.luba@....com>,
        Quentin Perret <qperret@...gle.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: Re: [PATCH V2] PM / EM: Micro optimization in em_cpu_energy

On 11/23/2020 11:29 AM, Pavankumar Kondeti wrote:
> When the sum of the utilization of CPUs in a power domain is zero,
> return the energy as 0 without doing any computations.
>
> Signed-off-by: Pavankumar Kondeti <pkondeti@...eaurora.org>
> ---
> V2: Fixed the function name in the commit message.
>
>   include/linux/energy_model.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
> index b67a51c..8810f1f 100644
> --- a/include/linux/energy_model.h
> +++ b/include/linux/energy_model.h
> @@ -103,6 +103,9 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
>   	struct em_perf_state *ps;
>   	int i, cpu;
>   
> +	if (!sum_util)
> +		return 0;
> +
>   	/*
>   	 * In order to predict the performance state, map the utilization of
>   	 * the most utilized CPU of the performance domain to a requested

If I'm to take this, please resend it with a CC to 
linux-pm@...r.kernel.org (and with the tags you've received so far).

Thanks!