linux-kernel - Re: [PATCH bpf-next v3 1/3] ima: Implement ima_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b6f7023-e1fe-b79b-fa06-b8edcce530de@fb.com>
Date:   Tue, 24 Nov 2020 09:35:02 -0800
From:   Yonghong Song <yhs@...com>
To:     KP Singh <kpsingh@...omium.org>, James Morris <jmorris@...ei.org>,
        <linux-kernel@...r.kernel.org>, <bpf@...r.kernel.org>,
        <linux-security-module@...r.kernel.org>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Florent Revest <revest@...omium.org>,
        Brendan Jackman <jackmanb@...omium.org>,
        Mimi Zohar <zohar@...ux.ibm.com>
Subject: Re: [PATCH bpf-next v3 1/3] ima: Implement ima_inode_hash



On 11/24/20 7:12 AM, KP Singh wrote:
> From: KP Singh <kpsingh@...gle.com>
> 
> This is in preparation to add a helper for BPF LSM programs to use
> IMA hashes when attached to LSM hooks. There are LSM hooks like
> inode_unlink which do not have a struct file * argument and cannot
> use the existing ima_file_hash API.
> 
> An inode based API is, therefore, useful in LSM based detections like an
> executable trying to delete itself which rely on the inode_unlink LSM
> hook.
> 
> Moreover, the ima_file_hash function does nothing with the struct file
> pointer apart from calling file_inode on it and converting it to an
> inode.
> 
> Signed-off-by: KP Singh <kpsingh@...gle.com>

There is no change for this patch compared to previous version,
so you can carry my Ack.

Acked-by: Yonghong Song <yhs@...com>