linux-kernel - Re: [PATCH 4/5] memory: renesas-rpc-if: Avoid use of C++ style comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Nov 2020 23:04:05 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Jiri Kosina <trivial@...nel.org>,
        Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Biju Das <biju.das.jz@...renesas.com>,
        Prabhakar <prabhakar.csengg@...il.com>
Subject: Re: [PATCH 4/5] memory: renesas-rpc-if: Avoid use of C++ style
 comments

On 11/24/20 2:25 PM, Lad Prabhakar wrote:

> Replace C++ style comment with C style.

   Thanks, I've overlooked this, and the header files should use C style comment,
not C++.
 
> While at it also replace the tab with a space between struct and
> struct name.

   No connection between these 2 changes, so there should be 2 patches, not 1.
Also, I'd like to ask you that they're left intact (unless it causes problems
for you).

> Suggested-by: Pavel Machek <pavel@...x.de>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
[...]

> diff --git a/include/memory/renesas-rpc-if.h b/include/memory/renesas-rpc-if.h
> index b8c7cc63065f..30ea6bd969b4 100644
> --- a/include/memory/renesas-rpc-if.h
> +++ b/include/memory/renesas-rpc-if.h
> @@ -19,7 +19,7 @@ enum rpcif_data_dir {
>  	RPCIF_DATA_OUT,
>  };
>  
> -struct	rpcif_op {
> +struct rpcif_op {
>  	struct {
>  		u8 buswidth;
>  		u8 opcode;
> @@ -57,7 +57,7 @@ struct	rpcif_op {
>  	} data;
>  };
>  
> -struct	rpcif {
> +struct rpcif {
>  	struct device *dev;
>  	void __iomem *dirmap;
>  	struct regmap *regmap;
> @@ -93,4 +93,4 @@ static inline void rpcif_disable_rpm(struct rpcif *rpc)
>  	pm_runtime_put_sync(rpc->dev);
>  }
>  
> -#endif // __RENESAS_RPC_IF_H
> +#endif /* __RENESAS_RPC_IF_H */

MBR, Sergei