linux-kernel - Re: [PATCH 0/3] MTD: SST SPI-NOR fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201124203500.GA487864@xaphan>
Date:   Tue, 24 Nov 2020 14:35:00 -0600
From:   Michael Auchter <michael.auchter@...com>
To:     Marco Felsch <m.felsch@...gutronix.de>
Cc:     tudor.ambarus@...rochip.com, miquel.raynal@...tlin.com,
        richard@....at, vigneshr@...com,
        sergei.shtylyov@...entembedded.com, boris.brezillon@...labora.com,
        michael@...le.cc, j.neuschaefer@....net,
        linux-mtd@...ts.infradead.org, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, joerg.hofrichter@...com
Subject: Re: [PATCH 0/3] MTD: SST SPI-NOR fixes

Hello Marco,

On Fri, Sep 11, 2020 at 04:47:00PM +0200, Marco Felsch wrote:
> Hi,
> 
> Patch 1-2: write path fixes
> The sst write path is completely broken since v5.7-rc1 and in rare cases
> since the support of the sst_write() function (49aac4aec53c).
> 
> Patch 3: cleanup
> 
> I've tested my patches with a small test app to ensure writes starting
> on an odd address and with dd to test even start addresses. My dut was
> an public available imx6q-sabrelite (rev.D).
> Other testers are welcome :)
> 
> Regards,
>   Marco
> 
> Marco Felsch (3):
>   mtd: spi-nor: sst: fix write support for SST_WRITE marked devices
>   mtd: spi-nor: sst: add missing write_enable
>   mtd: spi-nor: sst: move sst_write_second to local driver
> 
>  drivers/mtd/spi-nor/core.c  | 15 +++++++++------
>  drivers/mtd/spi-nor/sst.c   | 15 +++++++++++----
>  include/linux/mtd/spi-nor.h |  2 --
>  3 files changed, 20 insertions(+), 12 deletions(-)
> 
> -- 
> 2.20.1

My colleague, Joerg, has validated that these patches fix an issue we
saw where performing multi-byte writes to a SST25VF016B would fail.

Tested-by: Joerg Hofrichter <joerg.hofrichter@...com>

Thanks,
 Michael