lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Nov 2020 13:45:42 -0800 From: Kees Cook <keescook@...omium.org> To: Gabriel Krisman Bertazi <krisman@...labora.com> Cc: Jann Horn <jannh@...gle.com>, Arnd Bergmann <arnd@...nel.org>, Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Naresh Kamboju <naresh.kamboju@...aro.org>, open list <linux-kernel@...r.kernel.org>, Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, lkft-triage@...ts.linaro.org, Linux ARM <linux-arm-kernel@...ts.infradead.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andriin@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, Andy Lutomirski <luto@...capital.net>, Sumit Semwal <sumit.semwal@...aro.org>, Arnd Bergmann <arnd@...db.de>, YiFei Zhu <yifeifz2@...inois.edu> Subject: Re: [PATCH] entry: Fix boot for !CONFIG_GENERIC_ENTRY On Mon, Nov 23, 2020 at 10:54:58AM -0500, Gabriel Krisman Bertazi wrote: > Gabriel Krisman Bertazi <krisman@...labora.com> writes: > > > Jann Horn <jannh@...gle.com> writes: > >> As part of fixing this, it might be a good idea to put "enum > >> syscall_work_bit" behind a "#ifdef CONFIG_GENERIC_ENTRY" to avoid > >> future accidents like this? > > > > Hi Jan, Arnd, > > > > That is correct. This is a copy pasta mistake. My apologies. I didn't > > have a !GENERIC_ENTRY device to test, but just the ifdef would have > > caught it. > > I have patched it as suggested. Tested on qemu for arm32 and on bare > metal for x86-64. > > Once again, my apologies for the mistake. > > -- >8 -- > Subject: [PATCH] entry: Fix boot for !CONFIG_GENERIC_ENTRY > > A copy-pasta mistake tries to set SYSCALL_WORK flags instead of TIF > flags for !CONFIG_GENERIC_ENTRY. Also, add safeguards to catch this at > compilation time. > > Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org> > Suggested-by: Jann Horn <jannh@...gle.com> > Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com> Thanks for getting this fixed! 3136b93c3fb2 ("entry: Expose helpers to migrate TIF to SYSCALL_WORK flags") Reviewed-by: Kees Cook <keescook@...omium.org> -- Kees Cook
Powered by blists - more mailing lists