linux-kernel - Re: [PATCH v2 09/19] s390/vdso: Remove vdso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ec0d6b6-64b1-6095-c574-febca7478aa7@csgroup.eu>
Date:   Tue, 24 Nov 2020 07:22:45 +0100
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Dmitry Safonov <dima@...sta.com>, linux-kernel@...r.kernel.org
Cc:     Dmitry Safonov <0x7f454c46@...il.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Lutomirski <luto@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, Borislav Petkov <bp@...en8.de>,
        Catalin Marinas <catalin.marinas@....com>,
        Guo Ren <guoren@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
        Ingo Molnar <mingo@...hat.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Will Deacon <will@...nel.org>, x86@...nel.org,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH v2 09/19] s390/vdso: Remove vdso_base pointer from
 mm->context



Le 24/11/2020 à 01:29, Dmitry Safonov a écrit :
> Not used any more.

Same, what about mremap(), why can it be removed ?

> 
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: Heiko Carstens <hca@...ux.ibm.com>
> Cc: Vasily Gorbik <gor@...ux.ibm.com>
> Cc: linux-s390@...r.kernel.org
> Signed-off-by: Dmitry Safonov <dima@...sta.com>
> ---
>   arch/s390/include/asm/mmu.h |  1 -
>   arch/s390/kernel/vdso.c     | 10 ----------
>   2 files changed, 11 deletions(-)
> 
> diff --git a/arch/s390/include/asm/mmu.h b/arch/s390/include/asm/mmu.h
> index e12ff0f29d1a..095d0596f700 100644
> --- a/arch/s390/include/asm/mmu.h
> +++ b/arch/s390/include/asm/mmu.h
> @@ -15,7 +15,6 @@ typedef struct {
>   	unsigned long gmap_asce;
>   	unsigned long asce;
>   	unsigned long asce_limit;
> -	unsigned long vdso_base;
>   	/* The mmu context belongs to a secure guest. */
>   	atomic_t is_protected;
>   	/*
> diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c
> index 810b72f8985c..3f07711a07c1 100644
> --- a/arch/s390/kernel/vdso.c
> +++ b/arch/s390/kernel/vdso.c
> @@ -58,18 +58,9 @@ static vm_fault_t vdso_fault(const struct vm_special_mapping *sm,
>   	return 0;
>   }
>   
> -static int vdso_mremap(const struct vm_special_mapping *sm,
> -		       struct vm_area_struct *vma)
> -{
> -	current->mm->context.vdso_base = vma->vm_start;
> -
> -	return 0;
> -}
> -
>   static const struct vm_special_mapping vdso_mapping = {
>   	.name = "[vdso]",
>   	.fault = vdso_fault,
> -	.mremap = vdso_mremap,
>   };
>   
>   static int __init vdso_setup(char *str)
> @@ -204,7 +195,6 @@ int arch_setup_additional_pages(unsigned long *sysinfo_ehdr)
>   		goto out_up;
>   	}
>   
> -	current->mm->context.vdso_base = vdso_base;
>   	*sysinfo_ehdr = vdso_base;
>   	rc = 0;
>   
>