linux-kernel - [PATCH] ACPI: PM: Re-enable ACPI GPE if it's already enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201124073619.771940-1-kai.heng.feng@canonical.com>
Date:   Tue, 24 Nov 2020 15:36:19 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     rafael.j.wysocki@...el.com
Cc:     andy.shevchenko@...il.com, mika.westerberg@...ux.intel.com,
        hdegoede@...hat.com, bhelgaas@...gle.com,
        linux-acpi@...r.kernel.org, linux-pci@...r.kernel.org,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        linux-kernel@...r.kernel.org (open list)
Subject: [PATCH] ACPI: PM: Re-enable ACPI GPE if it's already enabled

Dell Precision 5550 fails to detect Thunderbolt device hotplug events,
once the Thunderbolt device and its root port are runtime-suspended to
D3cold.

While putting the entire hierarchy to D3cold, the root port ACPI GPE is
enabled via acpi_pci_propagate_wakeup() when suspending Thunderbolt
bridges/switches. So when putting the root port to D3cold as last step,
ACPI GPE is untouched as it's already enabled.

However, platform may need PCI devices to be in D3hot or PME enabled
prior enabling GPE to make it work. So re-enable ACPI GPE to address
this.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
---
 drivers/acpi/device_pm.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c
index 94d91c67aeae..dc25d9d204ae 100644
--- a/drivers/acpi/device_pm.c
+++ b/drivers/acpi/device_pm.c
@@ -757,11 +757,10 @@ static int __acpi_device_wakeup_enable(struct acpi_device *adev,
 
 	mutex_lock(&acpi_wakeup_lock);
 
-	if (wakeup->enable_count >= max_count)
-		goto out;
-
-	if (wakeup->enable_count > 0)
-		goto inc;
+	if (wakeup->enable_count > 0) {
+		acpi_disable_gpe(wakeup->gpe_device, wakeup->gpe_number);
+		acpi_disable_wakeup_device_power(adev);
+	}
 
 	error = acpi_enable_wakeup_device_power(adev, target_state);
 	if (error)
@@ -777,8 +776,8 @@ static int __acpi_device_wakeup_enable(struct acpi_device *adev,
 	acpi_handle_debug(adev->handle, "GPE%2X enabled for wakeup\n",
 			  (unsigned int)wakeup->gpe_number);
 
-inc:
-	wakeup->enable_count++;
+	if (wakeup->enable_count < max_count)
+		wakeup->enable_count++;
 
 out:
 	mutex_unlock(&acpi_wakeup_lock);
-- 
2.29.2