linux-kernel - Re: [PATCH] bdi: Fix error return code in alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201124074350.GM24489@pengutronix.de>
Date:   Tue, 24 Nov 2020 08:43:50 +0100
From:   Sascha Hauer <s.hauer@...gutronix.de>
To:     Wang ShaoBo <bobo.shaobowang@...wei.com>
Cc:     richard@....at, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, huawei.libin@...wei.com,
        cj.chengjian@...wei.com
Subject: Re: [PATCH] bdi: Fix error return code in alloc_wbufs()

On Sun, Nov 15, 2020 at 04:23:43PM +0800, Wang ShaoBo wrote:
> Fix to return PTR_ERR() error code from the error handling case instead
> fo 0 in function alloc_wbufs(), as done elsewhere in this function.
> 
> Fixes: 6a98bc4614de ("ubifs: Add authentication nodes to journal")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@...wei.com>
> ---
>  fs/ubifs/super.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Prefix for this patch should be "ubifs:" rather than "bdi:". With this:

Reviewed-by: Sascha Hauer <s.hauer@...gutronix.de>

Sascha

> 
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index cb3acfb7dd1f..dacbb999ae34 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -838,8 +838,10 @@ static int alloc_wbufs(struct ubifs_info *c)
>  		c->jheads[i].wbuf.jhead = i;
>  		c->jheads[i].grouped = 1;
>  		c->jheads[i].log_hash = ubifs_hash_get_desc(c);
> -		if (IS_ERR(c->jheads[i].log_hash))
> +		if (IS_ERR(c->jheads[i].log_hash)) {
> +			err = PTR_ERR(c->jheads[i].log_hash);
>  			goto out;
> +		}
>  	}
>  
>  	/*
> -- 
> 2.25.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |