lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Nov 2020 08:46:07 +0100 From: Sascha Hauer <s.hauer@...gutronix.de> To: Wang ShaoBo <bobo.shaobowang@...wei.com> Cc: richard@....at, herbert@...dor.apana.org.au, linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org, huawei.libin@...wei.com, cj.chengjian@...wei.com Subject: Re: [PATCH] ubifs: Fix error return code in ubifs_init_authentication() On Tue, Nov 24, 2020 at 02:33:20PM +0800, Wang ShaoBo wrote: > Fix to return PTR_ERR() error code from the error handling case where > ubifs_hash_get_desc() failed instead of 0 in ubifs_init_authentication(), > as done elsewhere in this function. > > Fixes: 49525e5eecca5 ("ubifs: Add helper functions for authentication support") > Signed-off-by: Wang ShaoBo <bobo.shaobowang@...wei.com> > --- > fs/ubifs/auth.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Sascha Hauer <s.hauer@...gutronix.de> Sascha > > diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c > index b93b3cd10bfd..8c50de693e1d 100644 > --- a/fs/ubifs/auth.c > +++ b/fs/ubifs/auth.c > @@ -338,8 +338,10 @@ int ubifs_init_authentication(struct ubifs_info *c) > c->authenticated = true; > > c->log_hash = ubifs_hash_get_desc(c); > - if (IS_ERR(c->log_hash)) > + if (IS_ERR(c->log_hash)) { > + err = PTR_ERR(c->log_hash); > goto out_free_hmac; > + } > > err = 0; > > -- > 2.17.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Powered by blists - more mailing lists