linux-kernel - Re: [PATCH] phram: Allow the user to set the erase page size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202011241736.9OeWc6hQ-lkp@intel.com>
Date:   Tue, 24 Nov 2020 17:12:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Guohua Zhong <zhongguohua1@...wei.com>, patrick@...motion.com,
        joern@...ybastard.org, miquel.raynal@...tlin.com, richard@....at,
        vigneshr@...com
Cc:     kbuild-all@...ts.01.org, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org, nixiaoming@...wei.com,
        wangle6@...wei.com, young.liuyang@...wei.com
Subject: Re: [PATCH] phram: Allow the user to set the erase page size.

Hi Guohua,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.10-rc5 next-20201123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Guohua-Zhong/phram-Allow-the-user-to-set-the-erase-page-size/20201124-141421
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git d5beb3140f91b1c8a3d41b14d729aefa4dcc58bc
config: i386-randconfig-r034-20201124 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/6ec7a653a663b6a638f767aa844a685fdd1463d2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Guohua-Zhong/phram-Allow-the-user-to-set-the-erase-page-size/20201124-141421
        git checkout 6ec7a653a663b6a638f767aa844a685fdd1463d2
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: drivers/mtd/devices/phram.o: in function `phram_setup':
>> drivers/mtd/devices/phram.c:266: undefined reference to `__umoddi3'

vim +266 drivers/mtd/devices/phram.c

   215	
   216	static int phram_setup(const char *val)
   217	{
   218		char buf[64 + 20 + 20 + 20], *str = buf;
   219		char *token[4];
   220		char *name;
   221		uint64_t start;
   222		uint64_t len;
   223		uint64_t erasesize = PAGE_SIZE;
   224		int i, ret;
   225	
   226		if (strnlen(val, sizeof(buf)) >= sizeof(buf))
   227			parse_err("parameter too long\n");
   228	
   229		strcpy(str, val);
   230		kill_final_newline(str);
   231	
   232		for (i = 0; i < 4; i++)
   233			token[i] = strsep(&str, ",");
   234	
   235		if (str)
   236			parse_err("too many arguments\n");
   237	
   238		if (!token[2])
   239			parse_err("not enough arguments\n");
   240	
   241		ret = parse_name(&name, token[0]);
   242		if (ret)
   243			return ret;
   244	
   245		ret = parse_num64(&start, token[1]);
   246		if (ret) {
   247			parse_err("illegal start address\n");
   248			goto error;
   249		}
   250	
   251		ret = parse_num64(&len, token[2]);
   252		if (ret) {
   253			parse_err("illegal device length\n");
   254			goto error;
   255		}
   256	
   257		if (token[3]) {
   258			ret = parse_num64(&erasesize, token[3]);
   259			if (ret) {
   260				parse_err("illegal erasesize\n");
   261				goto error;
   262			}
   263		}
   264	
   265		if (len == 0 || erasesize == 0 || erasesize > len
 > 266		    || erasesize > UINT_MAX || len % erasesize != 0) {
   267			parse_err("illegal erasesize or len\n");
   268			goto error;
   269		}
   270	
   271		ret = register_device(name, start, len, (uint32_t)erasesize);
   272		if (ret)
   273			goto error;
   274	
   275		pr_info("%s device: %#llx at %#llx for erasesize %#llx\n", name, len, start, erasesize);
   276		return 0;
   277	
   278	error:
   279		kfree(name);
   280		return ret;
   281	}
   282	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (36654 bytes)