linux-kernel - Re: [PATCH v2 4/4] iio: hid-sensors: Add hinge sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Nov 2020 11:39:51 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     "Ye, Xiang" <xiang.ye@...el.com>
CC:     Jonathan Cameron <jic23@...nel.org>, <jikos@...nel.org>,
        <srinivas.pandruvada@...ux.intel.com>,
        <linux-input@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] iio: hid-sensors: Add hinge sensor driver


> >   
> > > +
> > > +	  To compile this driver as a module, choose M here: the
> > > +	  module will be called hid-sensor-custom-hinge.
> > > +
> > >  endmenu
> > > diff --git a/drivers/iio/position/Makefile b/drivers/iio/position/Makefile
> > > index 3cbe7a734352..7a6225977a01 100644
> > > --- a/drivers/iio/position/Makefile
> > > +++ b/drivers/iio/position/Makefile
> > > @@ -5,3 +5,6 @@
> > >  # When adding new entries keep the list in alphabetical order
> > >  
> > >  obj-$(CONFIG_IQS624_POS)	+= iqs624-pos.o
> > > +
> > > +obj-$(CONFIG_HID_SENSOR_CUSTOM_HINGE) += hid-sensor-custom-hinge.o  
> > 
> > Alphabetical order preferred.
> >   
> > > +ccflags-y	+= -I$(srctree)/drivers/iio/common/hid-sensors  
> > 
> > Why?  
> hinge driver need to include #include "hid-sensor-trigger.h", if not using this cflag-y
> it should be #include "../common/hid-sensors/hid-sensor-trigger.h"

Even though that looks a bit ugly, I'd prefer that rather than having to realize we
were doing something not entirely obvious in the Makefile.

Thanks,

Jonathan