linux-kernel - RE: [PATCH v2 1/3] spi: convert to BIT() all spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Nov 2020 12:03:15 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        kernel test robot <lkp@...el.com>
CC:     linux-spi <linux-spi@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "Bogdan, Dragos" <Dragos.Bogdan@...log.com>
Subject: RE: [PATCH v2 1/3] spi: convert to BIT() all spi_device flags



> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Sent: Tuesday, November 24, 2020 1:50 PM
> To: kernel test robot <lkp@...el.com>
> Cc: Ardelean, Alexandru <alexandru.Ardelean@...log.com>; linux-spi <linux-
> spi@...r.kernel.org>; devicetree <devicetree@...r.kernel.org>; Linux Kernel
> Mailing List <linux-kernel@...r.kernel.org>; kbuild-all@...ts.01.org; Mark
> Brown <broonie@...nel.org>; Rob Herring <robh+dt@...nel.org>; Bogdan,
> Dragos <Dragos.Bogdan@...log.com>
> Subject: Re: [PATCH v2 1/3] spi: convert to BIT() all spi_device flags
> 
> On Tue, Nov 24, 2020 at 1:42 PM kernel test robot <lkp@...el.com> wrote:
> 
> > All warnings (new ones prefixed by >>):
> >
> >    In file included from drivers/spi/spidev.c:26:
> > >> include/uapi/linux/spi/spidev.h:33: warning: "SPI_CPHA" redefined
> >       33 | #define SPI_CPHA  0x01
> 
> Argh! Can we have only one set of flags?
>

My bad here for not catching this earlier.

It might be an idea to create a "include/uapi/linux/spi/spi.h" and include this in " include/uapi/linux/spi/spidev.h "
Then the " include/uapi/linux/spi/spi.h " would also be included in " include/linux/spi/spi.h "
We would naturally drop the BIT() macros for the uapi header.


> --
> With Best Regards,
> Andy Shevchenko