linux-kernel - Re: [PATCH] scsi: fnic: set scsi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72C36CF2-3675-42F0-A87D-7D9A179667EE@cisco.com>
Date:   Tue, 24 Nov 2020 01:27:58 +0000
From:   "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>
To:     "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>,
        "Satish Kharat (satishkh)" <satishkh@...co.com>
CC:     "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: fnic: set scsi_set_resid only for underflow

Looks good.
Reviewed-by: Arulprabhu Ponnusamy <arulponn@...co.com>

On 11/20/20, 5:51 PM, "Karan Tilak Kumar" <kartilak@...co.com> wrote:

    Fix to set scsi_set_resid() only if
    FCPIO_ICMND_CMPL_RESID_UNDER is set.

    Signed-off-by: Karan Tilak Kumar <kartilak@...co.com>
    Signed-off-by: Satish Kharat <satishkh@...co.com>
    ---
     drivers/scsi/fnic/fnic.h      | 2 +-
     drivers/scsi/fnic/fnic_scsi.c | 5 +++--
     2 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h
    index 7c5c911b2673..e4d399f41a0a 100644
    --- a/drivers/scsi/fnic/fnic.h
    +++ b/drivers/scsi/fnic/fnic.h
    @@ -39,7 +39,7 @@

     #define DRV_NAME		"fnic"
     #define DRV_DESCRIPTION		"Cisco FCoE HBA Driver"
    -#define DRV_VERSION		"1.6.0.51"
    +#define DRV_VERSION		"1.6.0.52"
     #define PFX			DRV_NAME ": "
     #define DFX                     DRV_NAME "%d: "

    diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
    index 16e66f5b833a..532c3c7ae372 100644
    --- a/drivers/scsi/fnic/fnic_scsi.c
    +++ b/drivers/scsi/fnic/fnic_scsi.c
    @@ -921,10 +921,11 @@ static void fnic_fcpio_icmnd_cmpl_handler(struct fnic *fnic,
     	case FCPIO_SUCCESS:
     		sc->result = (DID_OK << 16) | icmnd_cmpl->scsi_status;
     		xfer_len = scsi_bufflen(sc);
    -		scsi_set_resid(sc, icmnd_cmpl->residual);

    -		if (icmnd_cmpl->flags & FCPIO_ICMND_CMPL_RESID_UNDER)
    +		if (icmnd_cmpl->flags & FCPIO_ICMND_CMPL_RESID_UNDER) {
     			xfer_len -= icmnd_cmpl->residual;
    +			scsi_set_resid(sc, icmnd_cmpl->residual);
    +		}

     		if (icmnd_cmpl->scsi_status == SAM_STAT_CHECK_CONDITION)
     			atomic64_inc(&fnic_stats->misc_stats.check_condition);
    -- 
    2.29.2