linux-kernel - Re: [PATCH -next] sched/topology: Mark some symbols with static keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201124132428.GA1067355@google.com>
Date:   Tue, 24 Nov 2020 13:24:28 +0000
From:   Quentin Perret <qperret@...gle.com>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] sched/topology: Mark some symbols with static
 keyword

On Tuesday 24 Nov 2020 at 19:52:11 (+0800), Zou Wei wrote:
> Fix the following sparse warnings:
> 
> kernel/sched/topology.c:211:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
> kernel/sched/topology.c:212:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?
> 
> Signed-off-by: Zou Wei <zou_wei@...wei.com>

I think this wants:

Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")

But, with that:

Reviewed-by: Quentin Perret <qperret@...gle.com>

Thanks,
Quentin