linux-kernel - Re: [PATCH 2/2] mm/madvise: add process_madvise MADV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Nov 2020 14:42:09 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     Suren Baghdasaryan <surenb@...gle.com>
Cc:     akpm@...ux-foundation.org, mhocko@...nel.org, mhocko@...e.com,
        rientjes@...gle.com, willy@...radead.org, hannes@...xchg.org,
        guro@...com, riel@...riel.com, minchan@...nel.org,
        christian@...uner.io, timmurray@...gle.com,
        linux-api@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH 2/2] mm/madvise: add process_madvise MADV_DONTNEER support

On 11/23, Suren Baghdasaryan wrote:
>
> +	if (madvise_destructive(behavior)) {
> +		/* Allow destructive madvise only on a dying processes */
> +		if (!signal_group_exit(task->signal)) {

signal_group_exit(task) is true if this task execs and kills other threads,
see the comment above this helper.

I think you need !(task->signal->flags & SIGNAL_GROUP_EXIT).

Oleg.