[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPDyKFq3S2cdL0pCOLU7rfxFmNrQOZvproKVQ=Af7=sXHrFKOQ@mail.gmail.com>
Date: Tue, 24 Nov 2020 15:25:22 +0100
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Zhihao Cheng <chengzhihao1@...wei.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Robert Jarzmik <robert.jarzmik@...e.fr>,
"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
yi.zhang@...wei.com
Subject: Re: [PATCH] mmc: pxamci: Fix error return code in pxamci_probe
On Sat, 21 Nov 2020 at 03:11, Zhihao Cheng <chengzhihao1@...wei.com> wrote:
>
> Fix to return the error code from devm_gpiod_get_optional() instaed
> of 0 in pxamci_probe().
>
> Fixes: f54005b508b9a9d9c ("mmc: pxa: Use GPIO descriptor for power")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1@...wei.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/pxamci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index 29f6180a0036..316393c694d7 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -731,6 +731,7 @@ static int pxamci_probe(struct platform_device *pdev)
>
> host->power = devm_gpiod_get_optional(dev, "power", GPIOD_OUT_LOW);
> if (IS_ERR(host->power)) {
> + ret = PTR_ERR(host->power);
> dev_err(dev, "Failed requesting gpio_power\n");
> goto out;
> }
> --
> 2.25.4
>
Powered by blists - more mailing lists