linux-kernel - Re: [PATCH] clocksource/drivers/ingenic: Fix section mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61742e23-5b09-5c6c-fdaf-1500f089987e@wanyeetech.com>
Date:   Thu, 26 Nov 2020 01:34:50 +0800
From:   Zhou Yanjie <zhouyanjie@...yeetech.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>, tglx@...utronix.de
Cc:     linux-kernel@...r.kernel.org, paul@...pouillou.net,
        paul@...die.org.uk, hns@...delico.com,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] clocksource/drivers/ingenic: Fix section mismatch

Hi Daniel,

在 2020/11/25 下午6:23, Daniel Lezcano 写道:
> The function ingenic_tcu_get_clock() is annotated for the __init
> section but it is actually called from the online cpu callback.
>
> That will lead to a crash if a CPU is hotplugged after boot time.
>
> Remove the __init annotatation for the ingenic_tcu_get_clock()
> function.
>
> Fixes: f19d838d08fc (clocksource/drivers/ingenic: Add high resolution timer support for SMP/SMT)
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>   drivers/clocksource/ingenic-timer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)


Works fine on JZ4780, X1000, and X1830.

Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>


Thanks and best regards!


> diff --git a/drivers/clocksource/ingenic-timer.c b/drivers/clocksource/ingenic-timer.c
> index 58fd9189fab7..905fd6b163a8 100644
> --- a/drivers/clocksource/ingenic-timer.c
> +++ b/drivers/clocksource/ingenic-timer.c
> @@ -127,7 +127,7 @@ static irqreturn_t ingenic_tcu_cevt_cb(int irq, void *dev_id)
>   	return IRQ_HANDLED;
>   }
>   
> -static struct clk * __init ingenic_tcu_get_clock(struct device_node *np, int id)
> +static struct clk *ingenic_tcu_get_clock(struct device_node *np, int id)
>   {
>   	struct of_phandle_args args;
>