linux-kernel - Re: [PATCH] clk: tegra: Do not return 0 on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <160626998208.2717324.3699032150208058364@swboyd.mtv.corp.google.com>
Date:   Tue, 24 Nov 2020 18:06:22 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Michael Turquette <mturquette@...libre.com>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     Nicolin Chen <nicoleotsuka@...il.com>, jonathanh@...dia.com,
        pgaikwad@...dia.com, pdeschrijver@...dia.com,
        stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: tegra: Do not return 0 on failure

Quoting Thierry Reding (2020-11-20 08:18:39)
> On Fri, Nov 20, 2020 at 05:16:56PM +0100, Thierry Reding wrote:
> > On Wed, Oct 28, 2020 at 05:48:20PM -0700, Nicolin Chen wrote:
> > > Return values from read_dt_param() will be either TRUE (1) or
> > > FALSE (0), while dfll_fetch_pwm_params() returns 0 on success
> > > or an ERR code on failure.
> > > 
> > > So this patch fixes the bug of returning 0 on failure.
> > > 
> > > Fixes: 36541f0499fe ("clk: tegra: dfll: support PWM regulator control")
> > > Cc: <stable@...r.kernel.org>
> > > Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>
> > > ---
> > >  drivers/clk/tegra/clk-dfll.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > Mike, Stephen,
> > 
> > if you don't mind, I'll pick this up in the Tegra tree since there are a
> > few other Tegra clock patches on the list that may require coordination
> > inside the Tegra tree.
> 
> Also, I do plan on sending the collected set of patches to you for
> inclusion via PR at a later date, if that's okay with you.
> 

Ok sure.