linux-kernel - RE: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in argp assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b430a80dec14cb9aa612ff7e5dddac4@hisilicon.com>
Date:   Wed, 25 Nov 2020 18:22:24 +0000
From:   "Song Bao Hua (Barry Song)" <song.bao.hua@...ilicon.com>
To:     Colin King <colin.king@...onical.com>,
        Christoph Hellwig <hch@....de>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Robin Murphy <robin.murphy@....com>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] dma-mapping: fix an uninitialized pointer read due to
 typo in argp assignment



> -----Original Message-----
> From: Colin King [mailto:colin.king@...onical.com]
> Sent: Thursday, November 26, 2020 2:56 AM
> To: Song Bao Hua (Barry Song) <song.bao.hua@...ilicon.com>; Christoph
> Hellwig <hch@....de>; Marek Szyprowski <m.szyprowski@...sung.com>;
> Robin Murphy <robin.murphy@....com>; iommu@...ts.linux-foundation.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] dma-mapping: fix an uninitialized pointer read due to typo in
> argp assignment
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The assignment of argp is currently using argp as the source because of
> a typo. Fix this by assigning it the value passed in arg instead.
> 
> Addresses-Coverity: ("Uninitialized pointer read")
> Fixes: bfd2defed94d ("dma-mapping: add benchmark support for streaming
> DMA APIs")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Barry Song <song.bao.hua@...ilicon.com>

> ---
>  kernel/dma/map_benchmark.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/dma/map_benchmark.c b/kernel/dma/map_benchmark.c
> index ca616b664f72..e1e37603d01b 100644
> --- a/kernel/dma/map_benchmark.c
> +++ b/kernel/dma/map_benchmark.c
> @@ -192,7 +192,7 @@ static long map_benchmark_ioctl(struct file *file,
> unsigned int cmd,
>  		unsigned long arg)
>  {
>  	struct map_benchmark_data *map = file->private_data;
> -	void __user *argp = (void __user *)argp;
> +	void __user *argp = (void __user *)arg;
>  	u64 old_dma_mask;
> 
>  	int ret;
> --
> 2.29.2

Thanks
Barry