linux-kernel - Re: arch/powerpc/platforms/pseries/reconfig.c:394:30: error: 'ofdt_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Nov 2020 11:17:41 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Souptick Joarder <jrdr.linux@...il.com>,
        kernel test robot <lkp@...el.com>
Cc:     Alexey Dobriyan <adobriyan@...il.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: arch/powerpc/platforms/pseries/reconfig.c:394:30: error:
 'ofdt_proc_ops' defined but not used

On 11/25/20 11:13 AM, Souptick Joarder wrote:
> On Tue, Nov 24, 2020 at 12:40 PM kernel test robot <lkp@...el.com> wrote:
>>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   d5beb3140f91b1c8a3d41b14d729aefa4dcc58bc
>> commit: 97a32539b9568bb653683349e5a76d02ff3c3e2c proc: convert everything to "struct proc_ops"
>> date:   10 months ago
>> config: powerpc-randconfig-r002-20201124 (attached as .config)
>> compiler: powerpc64le-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=97a32539b9568bb653683349e5a76d02ff3c3e2c
>>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>>         git fetch --no-tags linus master
>>         git checkout 97a32539b9568bb653683349e5a76d02ff3c3e2c
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@...el.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>>> arch/powerpc/platforms/pseries/reconfig.c:394:30: error: 'ofdt_proc_ops' defined but not used [-Werror=unused-const-variable=]
>>      394 | static const struct proc_ops ofdt_proc_ops = {
>>          |                              ^~~~~~~~~~~~~
>>    cc1: all warnings being treated as errors
>> --
>>>> arch/powerpc/platforms/pseries/lparcfg.c:701:30: error: 'lparcfg_proc_ops' defined but not used [-Werror=unused-const-variable=]
>>      701 | static const struct proc_ops lparcfg_proc_ops = {
>>          |                              ^~~~~~~~~~~~~~~~
>>    cc1: all warnings being treated as errors
> 
> Both ofdt_proc_ops & lparcfg_proc_ops are used by proc_create().
> Not sure why it is throwing warnings.
> 

because this:

# CONFIG_PROC_FS is not set

>>
>> vim +/ofdt_proc_ops +394 arch/powerpc/platforms/pseries/reconfig.c
>>
>>    393
>>  > 394  static const struct proc_ops ofdt_proc_ops = {
>>    395          .proc_write     = ofdt_write,
>>    396          .proc_lseek     = noop_llseek,
>>    397  };
>>    398


-- 
~Randy