linux-kernel - Re: [PATCH] clk: imx6q: demote warning about pre-boot ldb_di

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Nov 2020 18:17:05 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>
Cc:     Ahmad Fatoum <a.fatoum@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: imx6q: demote warning about pre-boot ldb_di_clk reparenting

Quoting Ahmad Fatoum (2020-11-13 06:53:09)
> diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
> index ba33c79158de..b2e4b6234ac0 100644
> --- a/drivers/clk/imx/clk-imx6q.c
> +++ b/drivers/clk/imx/clk-imx6q.c
> @@ -337,10 +337,10 @@ static void init_ldb_clks(struct device_node *np, void __iomem *ccm_base)
>         of_assigned_ldb_sels(np, &sel[0][3], &sel[1][3]);
>  
>         for (i = 0; i < 2; i++) {
> -               /* Warn if a glitch might have been introduced already */
> +               /* Print a notice if a glitch might have been introduced already */
>                 if (sel[i][0] != 3) {
> -                       pr_warn("ccm: ldb_di%d_sel already changed from reset value: %d\n",
> -                               i, sel[i][0]);
> +                       pr_notice("ccm: ldb_di%d_sel already changed from reset value: %d\n",

Maybe the print should also say "Possible glitch"?