linux-kernel - RE: [char-misc-next 13/13] mei: virtio: virtualization frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f6181d8e80d4efb9464e9ec436800b7@intel.com>
Date:   Wed, 25 Nov 2020 21:18:04 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Wang, Yu1" <yu1.wang@...el.com>,
        "Liu, Shuo A" <shuo.a.liu@...el.com>,
        "virtio-dev@...ts.oasis-open.org" <virtio-dev@...ts.oasis-open.org>
Subject: RE: [char-misc-next 13/13] mei: virtio: virtualization frontend
 driver

> 
> On Tue, Aug 18, 2020 at 02:51:47PM +0300, Tomas Winkler wrote:
> > +#ifndef VIRTIO_ID_MEI
> > +#define VIRTIO_ID_MEI 0xFFFE /* virtio mei */ #endif
> 
> Just noticed now that this driver landed upstream.  Can I ask that you guys
> please register IDs with the virtio TC and not just pick a number at random?
> In particular this is way outside allowed range.
> 
> IDs should also be listed in include/uapi/linux/virtio_ids.h
> 
> If people just pick random numbers like this collistions are unavoidable.
> 
> List of IDs is part of virtio spec, chapter "Device Types".
> 
> Please do this change now before this goes out to production!
Okay,  this was assigned by ACRN, my impression was it's already registered.
Will take care of.
Thanks
Tomas