linux-kernel - Re: [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM and OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1606271044.32484.20.camel@mhfsdcap03>
Date:   Wed, 25 Nov 2020 10:24:04 +0800
From:   Chunfeng Yun <chunfeng.yun@...iatek.com>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
CC:     Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, Heiko Stuebner <heiko@...ech.de>,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH] phy/mediatek: Make PHY_MTK_XSPHY depend on HAS_IOMEM
 and OF_ADDRESS to fix build errors

Hi Tiezhu,

On Tue, 2020-11-24 at 17:47 +0800, Tiezhu Yang wrote:
> devm_ioremap_resource() will be not built in lib/devres.c if
> CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be
> not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not
> set, and then there exists two build errors about undefined
> reference to "devm_ioremap_resource" and "of_address_to_resource"
> in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY,
> make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>  drivers/phy/mediatek/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> index 50c5e93..66df045 100644
> --- a/drivers/phy/mediatek/Kconfig
> +++ b/drivers/phy/mediatek/Kconfig
> @@ -30,6 +30,8 @@ config PHY_MTK_XSPHY
>  	tristate "MediaTek XS-PHY Driver"
>  	depends on ARCH_MEDIATEK || COMPILE_TEST
>  	depends on OF
> +	depends on HAS_IOMEM
> +	depends on OF_ADDRESS
Why not add them into deconfig but here? In fact I don't know which way
is better and follow the kernel rule.

Vinod and Kishon, do you have any suggestion about this?

>  	select GENERIC_PHY
>  	help
>  	  Enable this to support the SuperSpeedPlus XS-PHY transceiver for