linux-kernel - Re: [PATCH] audit: remove unused macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhRGQOaNaPO19vKJhjaB9-wvX=bZF9X6spwOoi_C9MRb0A@mail.gmail.com>
Date:   Tue, 24 Nov 2020 23:31:07 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     Richard Guy Briggs <rgb@...hat.com>, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: remove unused macros

On Wed, Nov 11, 2020 at 7:38 PM Alex Shi <alex.shi@...ux.alibaba.com> wrote:
> From 5fef5f1b7b745b52bedc9c7eec9fc163202ad421 Mon Sep 17 00:00:00 2001
> From: Alex Shi <alex.shi@...ux.alibaba.com>
> Date: Fri, 6 Nov 2020 16:31:22 +0800
> Subject: [PATCH v3] audit: fix macros warnings
>
> Some unused macros could cause gcc warning:
> kernel/audit.c:68:0: warning: macro "AUDIT_UNINITIALIZED" is not used
> [-Wunused-macros]
> kernel/auditsc.c:104:0: warning: macro "AUDIT_AUX_IPCPERM" is not used
> [-Wunused-macros]
> kernel/auditsc.c:82:0: warning: macro "AUDITSC_INVALID" is not used
> [-Wunused-macros]
>
> AUDIT_UNINITIALIZED and AUDITSC_INVALID are still meaningful and should
> be in incorporated.
>
> Just remove AUDIT_AUX_IPCPERM.
>
> Thanks comments from Richard Guy Briggs and Paul Moore.
>
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: Paul Moore <paul@...l-moore.com>
> Cc: Richard Guy Briggs <rgb@...hat.com>
> Cc: Eric Paris <eparis@...hat.com>
> Cc: linux-audit@...hat.com
> Cc: linux-kernel@...r.kernel.org
> ---
>  kernel/audit.c   |  2 +-
>  kernel/auditsc.c | 11 +++++------
>  2 files changed, 6 insertions(+), 7 deletions(-)

Sorry for the delay, this was buried in my inbox but I've just merged
it into audit/next.  Thanks for your help and patience with this!

-- 
paul moore
www.paul-moore.com