linux-kernel - Re: [PATCH v3 17/17] x86/hyperv: handle IO-APIC when running as root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202011251316.PUcZIh8B-lkp@intel.com>
Date:   Wed, 25 Nov 2020 13:16:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Wei Liu <wei.liu@...nel.org>,
        Linux on Hyper-V List <linux-hyperv@...r.kernel.org>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        virtualization@...ts.linux-foundation.org,
        Linux Kernel List <linux-kernel@...r.kernel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        Vineeth Pillai <viremana@...ux.microsoft.com>,
        Sunil Muthuswamy <sunilmut@...rosoft.com>,
        Nuno Das Neves <nunodasneves@...ux.microsoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH v3 17/17] x86/hyperv: handle IO-APIC when running as root

Hi Wei,

I love your patch! Perhaps something to improve:

[auto build test WARNING on tip/x86/core]
[also build test WARNING on asm-generic/master iommu/next tip/timers/core pci/next linus/master v5.10-rc5]
[cannot apply to next-20201124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201125-011026
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 238c91115cd05c71447ea071624a4c9fe661f970
config: x86_64-randconfig-a003-20201125 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 77e98eaee2e8d4b9b297b66fda5b1e51e2a69999)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/591ad2444b6b7d63ab24ce8f16a4e367085bbb5d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Wei-Liu/Introducing-Linux-root-partition-support-for-Microsoft-Hypervisor/20201125-011026
        git checkout 591ad2444b6b7d63ab24ce8f16a4e367085bbb5d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   arch/x86/hyperv/irqdomain.c:305:3: error: field designator 'domain_free_irqs' does not refer to any field in type 'struct msi_domain_ops'
           .domain_free_irqs       = hv_msi_domain_free_irqs,
            ^
   arch/x86/hyperv/irqdomain.c:318:28: warning: no previous prototype for function 'hv_create_pci_msi_domain' [-Wmissing-prototypes]
   struct irq_domain * __init hv_create_pci_msi_domain(void)
                              ^
   arch/x86/hyperv/irqdomain.c:318:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct irq_domain * __init hv_create_pci_msi_domain(void)
   ^
   static 
>> arch/x86/hyperv/irqdomain.c:499:6: warning: no previous prototype for function 'hv_ioapic_ack_level' [-Wmissing-prototypes]
   void hv_ioapic_ack_level(struct irq_data *irq_data)
        ^
   arch/x86/hyperv/irqdomain.c:499:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void hv_ioapic_ack_level(struct irq_data *irq_data)
   ^
   static 
>> arch/x86/hyperv/irqdomain.c:526:5: warning: no previous prototype for function 'hv_acpi_register_gsi' [-Wmissing-prototypes]
   int hv_acpi_register_gsi(struct device *dev, u32 gsi, int trigger, int polarity)
       ^
   arch/x86/hyperv/irqdomain.c:526:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int hv_acpi_register_gsi(struct device *dev, u32 gsi, int trigger, int polarity)
   ^
   static 
>> arch/x86/hyperv/irqdomain.c:550:6: warning: no previous prototype for function 'hv_acpi_unregister_gsi' [-Wmissing-prototypes]
   void hv_acpi_unregister_gsi(u32 gsi)
        ^
   arch/x86/hyperv/irqdomain.c:550:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void hv_acpi_unregister_gsi(u32 gsi)
   ^
   static 
   4 warnings and 1 error generated.

vim +/hv_ioapic_ack_level +499 arch/x86/hyperv/irqdomain.c

   498	
 > 499	void hv_ioapic_ack_level(struct irq_data *irq_data)
   500	{
   501		/*
   502		 * Per email exchange with Hyper-V team, all is needed is write to
   503		 * LAPIC's EOI register. They don't support directed EOI to IO-APIC.
   504		 * Hyper-V handles it for us.
   505		 */
   506		apic_ack_irq(irq_data);
   507	}
   508	
   509	struct irq_chip hv_ioapic_chip __read_mostly = {
   510		.name			= "HV-IO-APIC",
   511		.irq_startup		= hv_ioapic_startup_irq,
   512		.irq_mask		= hv_ioapic_mask_irq,
   513		.irq_unmask		= hv_ioapic_unmask_irq,
   514		.irq_ack		= irq_chip_ack_parent,
   515		.irq_eoi		= hv_ioapic_ack_level,
   516		.irq_set_affinity	= hv_ioapic_set_affinity,
   517		.irq_retrigger		= irq_chip_retrigger_hierarchy,
   518		.irq_get_irqchip_state	= ioapic_irq_get_chip_state,
   519		.flags			= IRQCHIP_SKIP_SET_WAKE,
   520	};
   521	
   522	
   523	int (*native_acpi_register_gsi)(struct device *dev, u32 gsi, int trigger, int polarity);
   524	void (*native_acpi_unregister_gsi)(u32 gsi);
   525	
 > 526	int hv_acpi_register_gsi(struct device *dev, u32 gsi, int trigger, int polarity)
   527	{
   528		int irq = gsi;
   529	
   530	#ifdef CONFIG_X86_IO_APIC
   531		irq = native_acpi_register_gsi(dev, gsi, trigger, polarity);
   532		if (irq < 0) {
   533			pr_err("native_acpi_register_gsi failed %d\n", irq);
   534			return irq;
   535		}
   536	
   537		if (trigger) {
   538			irq_set_status_flags(irq, IRQ_LEVEL);
   539			irq_set_chip_and_handler_name(irq, &hv_ioapic_chip,
   540				handle_fasteoi_irq, "ioapic-fasteoi");
   541		} else {
   542			irq_clear_status_flags(irq, IRQ_LEVEL);
   543			irq_set_chip_and_handler_name(irq, &hv_ioapic_chip,
   544				handle_edge_irq, "ioapic-edge");
   545		}
   546	#endif
   547		return irq;
   548	}
   549	
 > 550	void hv_acpi_unregister_gsi(u32 gsi)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (25613 bytes)